Skip to content

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Sep 17, 2024

Upgrade to Lucene 9.12

This PR will not merge until 9.12 has been released, at which time the build dependencies will be updated.

This PR will be squash-merged, so as to simplify the backport to the 8.x branch.

benwtrent and others added 30 commits May 30, 2024 12:58
…torScorerFactoryTests (#109303)

This commit adds a couple of missing supported checks to org.elasticsearch.vec.VectorScorerFactoryTests. Without these the test try, and fail, to run on Windows.
Updated LuceneDocument to take advantage of looking up feature values on existing features and selecting the max when parsing multi-value sparse vectors
Just doing the minimal fixes to making this pass tests again and
compile. One trivial constructor adjustment and a few adjustments to
task count expectations in some tests from having Lucene fork less.
elasticsearchmachine and others added 3 commits September 19, 2024 06:11
@ChrisHegarty ChrisHegarty added test-windows Trigger CI checks on Windows test-full-bwc Trigger full BWC version matrix tests test-update-serverless test-arm Pull Requests that should be tested against arm agents :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team labels Sep 19, 2024
mayya-sharipova and others added 5 commits September 19, 2024 11:40
Currently multi term interval queries (prefix, wildcard, fuzzy, regexp and range) can
expand maximum to 128 terms. To reach parity with span queries that we want to deprecate,
set max expansions to indices.query.bool.max_clause_count which is used in span queries.

Relates to #110491
@ChrisHegarty ChrisHegarty marked this pull request as ready for review September 20, 2024 17:01
@ChrisHegarty ChrisHegarty requested review from a team as code owners September 20, 2024 17:01
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@benwtrent
Copy link
Member

Now if CI would just behave and we could see the actual impact of the Lucene upgrade ;)

@elasticsearchmachine
Copy link
Collaborator

Hi @ChrisHegarty, I've created a changelog YAML for you.

repositories {
// TODO: Temporary for Lucene RC builds. REMOVE
maven { url "https://dist.apache.org/repos/dist/dev/lucene/lucene-9.12.0-RC1-rev-f9cb943157870156af5f31cce315b95c08295c03/lucene/maven" }
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO REMOVE this when the RC build promoted.

@ChrisHegarty
Copy link
Contributor Author

ChrisHegarty commented Sep 21, 2024

closing in favour of #113333 - which is based off the more stable lucene_snapshot_9_12 branch. Which is effectively the same as this PR, but without updating the snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team test-arm Pull Requests that should be tested against arm agents test-full-bwc Trigger full BWC version matrix tests test-update-serverless test-windows Trigger CI checks on Windows >upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants